fix modelchain poa tests #1052
Merged
fix modelchain poa tests #1052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
While we're at it, I wonder about the name |
Closed
8 tasks
cwhanse
approved these changes
Sep 8, 2020
Member
cwhanse
left a comment
cwhanse
left a comment
There was a problem hiding this comment.
Were you able to figure out why the test passed the CI with that bad logic?
Member
Author
|
I was not able to figure that out, unfortunately. The fixtures are all function scoped either explicitly or by default, so I don't think they're the cause of the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).As discussed here,
test_prepare_inputs_from_poadidn't work when I ran the tests locally (as I expect from looking at the code) but the CI never failed (for reasons I still don't understand). This PR fixes that.This PR also changes the
modelchain.WEATHER_KEYS,POA_DATA_KEYS,TEMPERATURE_KEYS, andDATA_KEYSto tuples. The problem with using a set here is that it's unordered, so the_assign_weatherand_assign_total_irradcreate dataframes with column order that depends on the platform.